One small question below:
http://codereview.chromium.org/6348016/diff/1/src/ia32/lithium-ia32.cc File src/ia32/lithium-ia32.cc (right): http://codereview.chromium.org/6348016/diff/1/src/ia32/lithium-ia32.cc#newcode1861 src/ia32/lithium-ia32.cc:1861: if (pending_deoptimization_ast_id_ == instr->ast_id()) { This should really be: if (pending_deoptimization_ast_id_ != AstNode::kNoNumber) { ASSERT(pending_deoptimization_ast_id_ == instr->ast_id()); ... http://codereview.chromium.org/6348016/diff/1/src/ia32/lithium-ia32.cc#newcode1863 src/ia32/lithium-ia32.cc:1863: LInstruction* result = AssignEnvironment(lazy_bailout); I'm worried that the uses in this environment appear to come after the gap the precedes it, but the environment before the gap is the one that is recorded. Is that a problem? http://codereview.chromium.org/6348016/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
