Small comments, LGTM.
http://codereview.chromium.org/6390001/diff/1/src/x64/builtins-x64.cc File src/x64/builtins-x64.cc (right): http://codereview.chromium.org/6390001/diff/1/src/x64/builtins-x64.cc#newcode567 src/x64/builtins-x64.cc:567: // Pass the function and deoptimization type to the runtime system. This comment isn't correct. We grab the function from the stack. http://codereview.chromium.org/6390001/diff/1/src/x64/deoptimizer-x64.cc File src/x64/deoptimizer-x64.cc (right): http://codereview.chromium.org/6390001/diff/1/src/x64/deoptimizer-x64.cc#newcode321 src/x64/deoptimizer-x64.cc:321: // on the stack on windows and in r8 on windows. The remaining arguments are Comment mentions "on windows" and "on windows". http://codereview.chromium.org/6390001/diff/1/src/x64/deoptimizer-x64.cc#newcode380 src/x64/deoptimizer-x64.cc:380: __ movq(rcx, Operand(rsp, (kNumberOfRegisters - 1 - i) * kPointerSize)); I wonder why we don't count i down from kNumberOfRegisters to zero and __ pop(Operand(rbx, offset)) for all of them? http://codereview.chromium.org/6390001/diff/1/src/x64/deoptimizer-x64.cc#newcode388 src/x64/deoptimizer-x64.cc:388: int src_offset = i * kDoubleSize + kNumberOfRegisters * kPointerSize; Agree with lrn. http://codereview.chromium.org/6390001/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
