Done, please let me know whether it's ok to commit.
http://codereview.chromium.org/6248013/diff/6001/src/scanner-base.cc File src/scanner-base.cc (right): http://codereview.chromium.org/6248013/diff/6001/src/scanner-base.cc#newcode68 src/scanner-base.cc:68: : octal_pos_(-1) { } On 2011/01/24 07:59:37, Lasse Reichstein wrote:
Make -1 a constant in the Scanner class. Scanner::kNoOctalLocation would be a fine name. And give it a comment that says that -1 is outside the range of real
source
code.
Done. http://codereview.chromium.org/6248013/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
