http://codereview.chromium.org/6366010/diff/1/src/x64/assembler-x64.h File src/x64/assembler-x64.h (right):
http://codereview.chromium.org/6366010/diff/1/src/x64/assembler-x64.h#newcode405 src/x64/assembler-x64.h:405: // Index code (including REX.X) of 0x04 (esp) means no index register. esp -> rsp http://codereview.chromium.org/6366010/diff/1/src/x64/assembler-x64.h#newcode406 src/x64/assembler-x64.h:406: if (index_code != 0x04 && index_code == code) return true; What about using rsp.code() instead of 0x04 http://codereview.chromium.org/6366010/diff/1/src/x64/lithium-codegen-x64.cc File src/x64/lithium-codegen-x64.cc (right): http://codereview.chromium.org/6366010/diff/1/src/x64/lithium-codegen-x64.cc#newcode1285 src/x64/lithium-codegen-x64.cc:1285: Register temp = ToRegister(instr->TempAt(0)); No need to the temp register here (and in the lithium-x64 file) - just use r10 http://codereview.chromium.org/6366010/diff/1/src/x64/lithium-codegen-x64.cc#newcode1467 src/x64/lithium-codegen-x64.cc:1467: Register temp = ToRegister(instr->TempAt(0)); Use r10? http://codereview.chromium.org/6366010/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
