http://codereview.chromium.org/6247019/diff/1/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right):
http://codereview.chromium.org/6247019/diff/1/src/arm/code-stubs-arm.cc#newcode2609 src/arm/code-stubs-arm.cc:2609: masm->add(lr, pc, Operand(4)); // Compute return address: (pc + 8) + 4 On 2011/01/24 18:21:08, Mads Ager wrote:
You haven't changed this, but where is the '+ 8'?
The '+ 8' refers to that the pc is already at '+ 8' from the current instruction. Rephrased the comment. http://codereview.chromium.org/6247019/diff/1/src/arm/frames-arm.h File src/arm/frames-arm.h (right): http://codereview.chromium.org/6247019/diff/1/src/arm/frames-arm.h#newcode116 src/arm/frames-arm.h:116: static const int kCallerPCOffset = +1 * kPointerSize; On 2011/01/24 18:21:08, Mads Ager wrote:
Remove the +?
Done. http://codereview.chromium.org/6247019/diff/1/src/arm/frames-arm.h#newcode120 src/arm/frames-arm.h:120: static const int kCallerSPDisplacement = +2 * kPointerSize; On 2011/01/24 18:21:08, Mads Ager wrote:
Remove the +?
Done. http://codereview.chromium.org/6247019/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
