LGTM with comments addressed.
http://codereview.chromium.org/6324011/diff/1/src/x64/lithium-codegen-x64.cc File src/x64/lithium-codegen-x64.cc (right): http://codereview.chromium.org/6324011/diff/1/src/x64/lithium-codegen-x64.cc#newcode1595 src/x64/lithium-codegen-x64.cc:1595: Register result = ToRegister(instr->result()); GlobalObjectOperand() http://codereview.chromium.org/6324011/diff/1/src/x64/lithium-x64.cc File src/x64/lithium-x64.cc (right): http://codereview.chromium.org/6324011/diff/1/src/x64/lithium-x64.cc#newcode1189 src/x64/lithium-x64.cc:1189: LInstruction* result = DefineSameAsFirst(sub); Subtraction is not commutative. I don't think you can scramble the operands, to put the least constant on the left. http://codereview.chromium.org/6324011/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
