LGTM with comments addressed.
http://codereview.chromium.org/6382006/diff/6001/src/parser.cc File src/parser.cc (right): http://codereview.chromium.org/6382006/diff/6001/src/parser.cc#newcode3398 src/parser.cc:3398: if (name_loc.beg_pos != RelocInfo::kNoPosition) { Use name_loc.IsValid() here and below. http://codereview.chromium.org/6382006/diff/6001/src/scanner-base.h File src/scanner-base.h (right): http://codereview.chromium.org/6382006/diff/6001/src/scanner-base.h#newcode276 src/scanner-base.h:276: return beg_pos >= 0 && end_pos >= 0; How about ... && end_pos >= beg_pos; Seems more "valid" to me :) http://codereview.chromium.org/6382006/diff/6001/test/mjsunit/strict-mode.js File test/mjsunit/strict-mode.js (right): http://codereview.chromium.org/6382006/diff/6001/test/mjsunit/strict-mode.js#newcode91 test/mjsunit/strict-mode.js:91: CheckStrictMode("function foo(a, b, c, d, b) {}", SyntaxError) How about checking that it's not an error in non-strict mode? http://codereview.chromium.org/6382006/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
