http://codereview.chromium.org/6342019/diff/1/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right):
http://codereview.chromium.org/6342019/diff/1/src/arm/code-stubs-arm.cc#newcode2505 src/arm/code-stubs-arm.cc:2505: __ PrepareCallCFunction(4, scratch1); // Two doubles count as 4 arguments. On 2011/01/25 14:23:17, Mads Ager wrote:
Long line.
Done. http://codereview.chromium.org/6342019/diff/1/src/arm/macro-assembler-arm.h File src/arm/macro-assembler-arm.h (right): http://codereview.chromium.org/6342019/diff/1/src/arm/macro-assembler-arm.h#newcode744 src/arm/macro-assembler-arm.h:744: void JumpIfSmi(Register reg, Label* on_smi); On 2011/01/25 14:25:09, Mads Ager wrote:
Don't we have BranchOnSmi? Either use that one or get rid of it?
You are right - changed to use BranchOnSmi. There is a mixture of BranchOn* and JumpIf* in the ARM macro assembler. http://codereview.chromium.org/6342019/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
