Yes, so we can't have a DoubleRegister, since ia32 can't make an Operand from an XMM register. /L
On Tue, Jan 25, 2011 at 15:21, William Hesse <[email protected]> wrote: > Exactly. But on x64 we can only make operands from stack slots, and > registers or xmm registers from the right thing. > So exactly. > > > On Tue, Jan 25, 2011 at 3:01 PM, <[email protected]> wrote: > >> >> >> http://codereview.chromium.org/6262013/diff/1/src/x64/lithium-codegen-x64.cc >> File src/x64/lithium-codegen-x64.cc (right): >> >> >> http://codereview.chromium.org/6262013/diff/1/src/x64/lithium-codegen-x64.cc#newcode1486 >> src/x64/lithium-codegen-x64.cc:1486: >> ASSERT(!argument->IsDoubleRegister()); >> I don't think it can happen (from reading the ia32 code, where they just >> make an Operand in all non-constant cases). >> >> >> http://codereview.chromium.org/6262013/ >> > > > > -- > William Hesse > Software Engineer > [email protected] > > Google Denmark ApS > Frederiksborggade 20B, 1 sal > 1360 København K > Denmark > CVR nr. 28 86 69 84 > > If you received this communication by mistake, please don't forward it to > anyone else (it may contain confidential or privileged information), please > erase all copies of it, including all attachments, and please let the sender > know it went to the wrong person. Thanks. > > -- Lasse R.H. Nielsen [email protected] 'Faith without judgement merely degrades the spirit divine' Google Denmark ApS - Frederiksborggade 20B, 1 sal - 1360 København K - Denmark - CVR nr. 28 86 69 84 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
