LGTM
Regarding the failing test you say "it is trying to write to sp - 4". Do you
mean sp here? If you do then something is off, as we should never write
below
the stack pointer. Otherwise could it be related to
http://code.google.com/p/v8/issues/detail?id=1067?
http://codereview.chromium.org/6311010/diff/30001/src/arm/lithium-codegen-arm.cc
File src/arm/lithium-codegen-arm.cc (right):
http://codereview.chromium.org/6311010/diff/30001/src/arm/lithium-codegen-arm.cc#newcode337
src/arm/lithium-codegen-arm.cc:337: // and the first word of the double
in the fixed part of the frame.
I know that you copied from above, but I don't like the constants 3 and
-1 here. Maybe we should have a class OptimizedFrameConstants in
frames-arm.h as well.
It doesn't need to be in this change though.
http://codereview.chromium.org/6311010/diff/30001/src/arm/lithium-gap-resolver-arm.cc
File src/arm/lithium-gap-resolver-arm.cc (right):
http://codereview.chromium.org/6311010/diff/30001/src/arm/lithium-gap-resolver-arm.cc#newcode235
src/arm/lithium-gap-resolver-arm.cc:235: // destroys ip, since that
happens before the value is read.
Maybe add something like "when we can't use ip use the low word of the
double scratch register as a temporary".
http://codereview.chromium.org/6311010/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
