Reviewers: Mads Ager,
Description:
ARM: Make the ARM hardware builder green
Fix a bug in the --debug-code alignment check in the C entry stub.
Don't force the --debug-code flag in the ARM disassembler tests. The
framework
does support passing flags and the test runner will when running tests in
debug
mode.
Skip some deserialization tests which crashes from time to time.
Please review this at http://codereview.chromium.org/6393007/
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/arm/code-stubs-arm.cc
M test/cctest/cctest.status
M test/cctest/test-assembler-arm.cc
M test/cctest/test-assembler-mips.cc
Index: src/arm/code-stubs-arm.cc
===================================================================
--- src/arm/code-stubs-arm.cc (revision 6483)
+++ src/arm/code-stubs-arm.cc (working copy)
@@ -3160,7 +3160,7 @@
if (frame_alignment > kPointerSize) {
Label alignment_as_expected;
ASSERT(IsPowerOf2(frame_alignment));
- __ tst(r2, Operand(frame_alignment_mask));
+ __ tst(sp, Operand(frame_alignment_mask));
__ b(eq, &alignment_as_expected);
// Don't use Check here, as it will call Runtime_Abort re-entering
here.
__ stop("Unexpected alignment");
Index: test/cctest/cctest.status
===================================================================
--- test/cctest/cctest.status (revision 6483)
+++ test/cctest/cctest.status (working copy)
@@ -101,6 +101,11 @@
test-debug/DebuggerAgentProtocolOverflowHeader: SKIP
test-sockets/Socket: SKIP
+# BUG(1075): Some deserialization tests fail om ARM
+cctest/test-serialize/Deserialize: SKIP
+cctest/test-serialize/DeserializeFromSecondSerializationAndRunScript2: SKIP
+cctest/test-serialize/DeserializeAndRunScript2: SKIP
+cctest/test-serialize/DeserializeFromSecondSerialization: SKIP
##############################################################################
[ $arch == arm && $crankshaft ]
Index: test/cctest/test-assembler-arm.cc
===================================================================
--- test/cctest/test-assembler-arm.cc (revision 6483)
+++ test/cctest/test-assembler-arm.cc (working copy)
@@ -45,11 +45,7 @@
static v8::Persistent<v8::Context> env;
-// The test framework does not accept flags on the command line, so we set
them
static void InitializeVM() {
- // enable generation of comments
- FLAG_debug_code = true;
-
if (env.IsEmpty()) {
env = v8::Context::New();
}
Index: test/cctest/test-assembler-mips.cc
===================================================================
--- test/cctest/test-assembler-mips.cc (revision 6483)
+++ test/cctest/test-assembler-mips.cc (working copy)
@@ -47,14 +47,10 @@
static v8::Persistent<v8::Context> env;
-// The test framework does not accept flags on the command line, so we set
them.
static void InitializeVM() {
// Disable compilation of natives.
FLAG_disable_native_files = true;
- // Enable generation of comments.
- FLAG_debug_code = true;
-
if (env.IsEmpty()) {
env = v8::Context::New();
}
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
