Revision: 6484
Author: [email protected]
Date: Wed Jan 26 01:52:25 2011
Log: ARM: Make the ARM hardware builder green
Fix a bug in the --debug-code alignment check in the C entry stub.
Don't force the --debug-code flag in the ARM disassembler tests. The
framework does support passing flags and the test runner will when running
tests in debug mode.
Skip some deserialization tests which crashes from time to time.
Review URL: http://codereview.chromium.org/6393007
http://code.google.com/p/v8/source/detail?r=6484
Modified:
/branches/bleeding_edge/src/arm/code-stubs-arm.cc
/branches/bleeding_edge/test/cctest/cctest.status
/branches/bleeding_edge/test/cctest/test-assembler-arm.cc
/branches/bleeding_edge/test/cctest/test-assembler-mips.cc
=======================================
--- /branches/bleeding_edge/src/arm/code-stubs-arm.cc Wed Jan 26 00:32:54
2011
+++ /branches/bleeding_edge/src/arm/code-stubs-arm.cc Wed Jan 26 01:52:25
2011
@@ -3160,7 +3160,7 @@
if (frame_alignment > kPointerSize) {
Label alignment_as_expected;
ASSERT(IsPowerOf2(frame_alignment));
- __ tst(r2, Operand(frame_alignment_mask));
+ __ tst(sp, Operand(frame_alignment_mask));
__ b(eq, &alignment_as_expected);
// Don't use Check here, as it will call Runtime_Abort re-entering
here.
__ stop("Unexpected alignment");
=======================================
--- /branches/bleeding_edge/test/cctest/cctest.status Mon Jan 24 23:57:56
2011
+++ /branches/bleeding_edge/test/cctest/cctest.status Wed Jan 26 01:52:25
2011
@@ -101,6 +101,11 @@
test-debug/DebuggerAgentProtocolOverflowHeader: SKIP
test-sockets/Socket: SKIP
+# BUG(1075): Some deserialization tests fail om ARM
+cctest/test-serialize/Deserialize: SKIP
+cctest/test-serialize/DeserializeFromSecondSerializationAndRunScript2: SKIP
+cctest/test-serialize/DeserializeAndRunScript2: SKIP
+cctest/test-serialize/DeserializeFromSecondSerialization: SKIP
##############################################################################
[ $arch == arm && $crankshaft ]
=======================================
--- /branches/bleeding_edge/test/cctest/test-assembler-arm.cc Tue Dec 7
03:01:02 2010
+++ /branches/bleeding_edge/test/cctest/test-assembler-arm.cc Wed Jan 26
01:52:25 2011
@@ -45,11 +45,7 @@
static v8::Persistent<v8::Context> env;
-// The test framework does not accept flags on the command line, so we set
them
static void InitializeVM() {
- // enable generation of comments
- FLAG_debug_code = true;
-
if (env.IsEmpty()) {
env = v8::Context::New();
}
=======================================
--- /branches/bleeding_edge/test/cctest/test-assembler-mips.cc Tue Dec 7
03:01:02 2010
+++ /branches/bleeding_edge/test/cctest/test-assembler-mips.cc Wed Jan 26
01:52:25 2011
@@ -47,14 +47,10 @@
static v8::Persistent<v8::Context> env;
-// The test framework does not accept flags on the command line, so we set
them.
static void InitializeVM() {
// Disable compilation of natives.
FLAG_disable_native_files = true;
- // Enable generation of comments.
- FLAG_debug_code = true;
-
if (env.IsEmpty()) {
env = v8::Context::New();
}
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
