Reviewers: Mads Ager, Description: ARM: Fix the type recording binary operation stub subtract
Failure exposed by Sputning tests where the generic case tried to string add for
subtract. Please review this at http://codereview.chromium.org/6339013/ SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/arm/code-stubs-arm.cc Index: src/arm/code-stubs-arm.cc =================================================================== --- src/arm/code-stubs-arm.cc (revision 6484) +++ src/arm/code-stubs-arm.cc (working copy) @@ -2695,7 +2695,9 @@ __ bind(&call_runtime); // Try to add strings before calling runtime. - GenerateAddStrings(masm); + if (op_ == Token::ADD) { + GenerateAddStrings(masm); + } GenericBinaryOpStub stub(op_, mode_, r1, r0); __ TailCallStub(&stub); @@ -2703,6 +2705,8 @@ void TypeRecordingBinaryOpStub::GenerateAddStrings(MacroAssembler* masm) { + ASSERT(op_ == Token::ADD); + Register left = r1; Register right = r0; Label call_runtime; -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
