LGTM.
http://codereview.chromium.org/6399002/diff/1/src/hydrogen-instructions.h File src/hydrogen-instructions.h (left): http://codereview.chromium.org/6399002/diff/1/src/hydrogen-instructions.h#oldcode2747 src/hydrogen-instructions.h:2747: virtual bool DataEquals(HValue* other) const { return true; } The default implementation of DataEquals is unsafe returning true - maybe making it unreachable to make sure all instructions that use GVN override it. http://codereview.chromium.org/6399002/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
