Revision: 6491
Author: [email protected]
Date: Wed Jan 26 05:37:51 2011
Log: Clean up Hydrogen's HLoadFunctionPrototype.
This instruction was setting an incorrect collection of Changes/Depends
flags.
Review URL: http://codereview.chromium.org/6399002
http://code.google.com/p/v8/source/detail?r=6491
Modified:
/branches/bleeding_edge/src/hydrogen-instructions.h
=======================================
--- /branches/bleeding_edge/src/hydrogen-instructions.h Thu Jan 20 04:56:34
2011
+++ /branches/bleeding_edge/src/hydrogen-instructions.h Wed Jan 26 05:37:51
2011
@@ -133,10 +133,9 @@
// HFixedArrayLength
// HJSArrayLength
// HLoadElements
-// HTypeofIs
+// HLoadFunctionPrototype
// HLoadNamedField
// HLoadNamedGeneric
-// HLoadFunctionPrototype
// HPushArgument
// HStringLength
// HTypeof
@@ -148,6 +147,7 @@
// HIsNull
// HIsObject
// HIsSmi
+// HTypeofIs
// HValueOf
// HUnknownOSRValue
// HPhi
@@ -224,12 +224,12 @@
V(LeaveInlined) \
V(LoadContextSlot) \
V(LoadElements) \
+ V(LoadFunctionPrototype) \
V(LoadGlobal) \
V(LoadKeyedFastElement) \
V(LoadKeyedGeneric) \
V(LoadNamedField) \
V(LoadNamedGeneric) \
- V(LoadFunctionPrototype) \
V(Mod) \
V(Mul) \
V(ObjectLiteral) \
@@ -268,7 +268,6 @@
V(GlobalVars) \
V(Maps) \
V(ArrayLengths) \
- V(FunctionPrototypes) \
V(OsrEntries)
#define DECLARE_INSTRUCTION(type) \
@@ -2732,7 +2731,8 @@
explicit HLoadFunctionPrototype(HValue* function)
: HUnaryOperation(function) {
set_representation(Representation::Tagged());
- SetFlagMask(kDependsOnFunctionPrototypes);
+ SetFlag(kUseGVN);
+ SetFlag(kDependsOnCalls);
}
HValue* function() const { return OperandAt(0); }
@@ -2742,9 +2742,6 @@
}
DECLARE_CONCRETE_INSTRUCTION(LoadFunctionPrototype, "load_function_prototype")
-
- protected:
- virtual bool DataEquals(HValue* other) const { return true; }
};
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
