Good catch. I've eliminated it and all other implementations that were unused. I added verification code to HInstruction::Verify. Please take another quick look.
On Wed, Jan 26, 2011 at 3:13 PM, <[email protected]> wrote: > LGTM. > > > http://codereview.chromium.org/6255013/diff/1/src/hydrogen-instructions.h > File src/hydrogen-instructions.h (right): > > > http://codereview.chromium.org/6255013/diff/1/src/hydrogen-instructions.h#newcode2905 > src/hydrogen-instructions.h:2905: virtual bool DataEquals(HValue* other) > const { > Since stores do not participate in GVN we don't need DataEquals here. > > > http://codereview.chromium.org/6255013/ > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
