Reviewers: Mads Ager, Description: ARM: Try to fix broken commit r6504
Commit contained wrong assert and was missing call to the runtime system for MUL. [email protected] Please review this at http://codereview.chromium.org/6338019/ SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/arm/code-stubs-arm.cc Index: src/arm/code-stubs-arm.cc =================================================================== --- src/arm/code-stubs-arm.cc (revision 6504) +++ src/arm/code-stubs-arm.cc (working copy) @@ -2628,7 +2628,7 @@ void TypeRecordingBinaryOpStub::GenerateInt32Stub(MacroAssembler* masm) { - ASSERT(op_ == Token::ADD || op_ == Token::SUB || op_ == Token::SUB); + ASSERT(op_ == Token::ADD || op_ == Token::SUB || op_ == Token::MUL); ASSERT(operands_type_ == TRBinaryOpIC::INT32); @@ -2773,6 +2773,9 @@ case Token::SUB: __ InvokeBuiltin(Builtins::SUB, JUMP_JS); break; + case Token::MUL: + __ InvokeBuiltin(Builtins::MUL, JUMP_JS); + break; default: UNREACHABLE(); } -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
