Still LGTM. It would be great if we could come up with some easy tests for
the
path in optimized code that needs the check.
http://codereview.chromium.org/6306014/diff/5001/src/arm/lithium-arm.cc
File src/arm/lithium-arm.cc (right):
http://codereview.chromium.org/6306014/diff/5001/src/arm/lithium-arm.cc#newcode1605
src/arm/lithium-arm.cc:1605: LOperand* temp = instr->check_hole_value()
? TempRegister() : NULL;
OK, but since almost every line has to check the same flag, I'd split it
into:
if (instr->check_hole_value()) {
LOperand* temp = TempRegister();
LOperand* value = UseRegister(instr->value());
LStoreGlobal* result = new LStoreGlobal(value, temp);
return AssignEnvironment(result);
} else {
LOperand* value = UseRegisterAtStart(instr->value());
return new LStoreGlobal(value, NULL);
}
http://codereview.chromium.org/6306014/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
