LGTM, maybe we should add:
ASSERT(code->safepoint_table_start() - last_pc_offset > 0);
To the deoptimizer-x64 (and ia32+arm for that sake) before assigning this
to an
unsigned integer.
http://codereview.chromium.org/6397002/diff/1/src/x64/lithium-codegen-x64.cc
File src/x64/lithium-codegen-x64.cc (right):
http://codereview.chromium.org/6397002/diff/1/src/x64/lithium-codegen-x64.cc#newcode1388
src/x64/lithium-codegen-x64.cc:1388: Abort("Sometimes triggers bug in
deoptimization. Keep disabled for now.");
With the fix for the conditional jump to a byte* we should be able to
enable this method as well.
http://codereview.chromium.org/6397002/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev