Reviewers: Erik Corry,
Message:
Erik,
may you have a look?
Description:
Do not set result_ prematurely.
If ConfigureGlobalObjects below will fail, we still decide that
initialidation
went smoothly as we check emptiness of result_ handle to see if
initialisation
failed or not.
Please review this at http://codereview.chromium.org/6347021/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/bootstrapper.cc
Index: src/bootstrapper.cc
diff --git a/src/bootstrapper.cc b/src/bootstrapper.cc
index
cae1a9a288e9ab97250411f255a61e2cae55a411..16a186fe6e9cb1b4979553e895620855ff56e4c8
100644
--- a/src/bootstrapper.cc
+++ b/src/bootstrapper.cc
@@ -1805,9 +1805,8 @@ Genesis::Genesis(Handle<Object> global_object,
AddToWeakGlobalContextList(*global_context_);
Top::set_context(*global_context_);
i::Counters::contexts_created_by_snapshot.Increment();
- result_ = global_context_;
JSFunction* empty_function =
- JSFunction::cast(result_->function_map()->prototype());
+ JSFunction::cast(global_context_->function_map()->prototype());
empty_function_ = Handle<JSFunction>(empty_function);
Handle<GlobalObject> inner_global;
Handle<JSGlobalProxy> global_proxy =
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
