Revision: 6515
Author: [email protected]
Date: Thu Jan 27 06:25:37 2011
Log: Better name for ShouldReturnException which actually should be
ShouldReportException.
Review URL: http://codereview.chromium.org/6368019
http://code.google.com/p/v8/source/detail?r=6515
Modified:
/branches/bleeding_edge/src/top.cc
/branches/bleeding_edge/src/top.h
=======================================
--- /branches/bleeding_edge/src/top.cc Wed Jan 26 00:32:54 2011
+++ /branches/bleeding_edge/src/top.cc Thu Jan 27 06:25:37 2011
@@ -806,7 +806,7 @@
}
-bool Top::ShouldReturnException(bool* is_caught_externally,
+bool Top::ShouldReportException(bool* is_caught_externally,
bool catchable_by_javascript) {
// Find the top-most try-catch handler.
StackHandler* handler =
@@ -847,15 +847,15 @@
Handle<Object> exception_handle(exception_object);
// Determine reporting and whether the exception is caught externally.
- bool is_caught_externally = false;
bool is_out_of_memory = exception == Failure::OutOfMemoryException();
bool is_termination_exception = exception ==
Heap::termination_exception();
bool catchable_by_javascript = !is_termination_exception
&& !is_out_of_memory;
// Only real objects can be caught by JS.
ASSERT(!catchable_by_javascript || is_object);
- bool should_return_exception =
- ShouldReturnException(&is_caught_externally,
catchable_by_javascript);
- bool report_exception = catchable_by_javascript &&
should_return_exception;
+ bool is_caught_externally = false;
+ bool should_report_exception =
+ ShouldReportException(&is_caught_externally,
catchable_by_javascript);
+ bool report_exception = catchable_by_javascript &&
should_report_exception;
#ifdef ENABLE_DEBUGGER_SUPPORT
// Notify debugger of exception.
=======================================
--- /branches/bleeding_edge/src/top.h Wed Jan 26 00:32:54 2011
+++ /branches/bleeding_edge/src/top.h Thu Jan 27 06:25:37 2011
@@ -386,7 +386,9 @@
static void DoThrow(MaybeObject* exception,
MessageLocation* location,
const char* message);
- static bool ShouldReturnException(bool* is_caught_externally,
+ // Checks if exception should be reported and finds out if it's
+ // caught externally.
+ static bool ShouldReportException(bool* is_caught_externally,
bool catchable_by_javascript);
// Attempts to compute the current source location, storing the
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
