Revision: 6516 Author: [email protected] Date: Thu Jan 27 08:17:13 2011 Log: Do not set result_ prematurely.
If ConfigureGlobalObjects below will fail, we still decide that initialidation went smoothly as we check emptiness of result_ handle to see if initialisation
failed or not. Review URL: http://codereview.chromium.org/6347021 http://code.google.com/p/v8/source/detail?r=6516 Modified: /branches/bleeding_edge/src/bootstrapper.cc ======================================= --- /branches/bleeding_edge/src/bootstrapper.cc Tue Dec 14 10:53:48 2010 +++ /branches/bleeding_edge/src/bootstrapper.cc Thu Jan 27 08:17:13 2011 @@ -1805,9 +1805,8 @@ AddToWeakGlobalContextList(*global_context_); Top::set_context(*global_context_); i::Counters::contexts_created_by_snapshot.Increment(); - result_ = global_context_; JSFunction* empty_function = - JSFunction::cast(result_->function_map()->prototype()); + JSFunction::cast(global_context_->function_map()->prototype()); empty_function_ = Handle<JSFunction>(empty_function); Handle<GlobalObject> inner_global; Handle<JSGlobalProxy> global_proxy = -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
