Thanks a lot for review, Mads.

Submitting.


http://codereview.chromium.org/6335016/diff/1/src/assembler.cc
File src/assembler.cc (right):

http://codereview.chromium.org/6335016/diff/1/src/assembler.cc#newcode717
src/assembler.cc:717: return
ExternalReference(Top::k_pending_exception_address);
On 2011/01/27 13:52:49, Mads Ager wrote:
Is there a reason why this is accessing a member and the
scheduled_exception_address one is calling an accessor?

The only one: older code used this idiom.

Removed.  As a bonus point I removed this constant from
TOP_LIST_ADDRESS_LIST.

http://codereview.chromium.org/6335016/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to