LGTM, with comments.
http://codereview.chromium.org/6350021/diff/1/src/ia32/code-stubs-ia32.cc File src/ia32/code-stubs-ia32.cc (right): http://codereview.chromium.org/6350021/diff/1/src/ia32/code-stubs-ia32.cc#newcode48 src/ia32/code-stubs-ia32.cc:48: __ ret(0); Ret() is an alternative to ret(0) http://codereview.chromium.org/6350021/diff/1/src/x64/code-stubs-x64.cc File src/x64/code-stubs-x64.cc (right): http://codereview.chromium.org/6350021/diff/1/src/x64/code-stubs-x64.cc#newcode43 src/x64/code-stubs-x64.cc:43: // It is assumed to be already smi-checked. This comment is probably wrong. Otherwise, we wouldn't smi-check here. http://codereview.chromium.org/6350021/diff/1/src/x64/code-stubs-x64.cc#newcode47 src/x64/code-stubs-x64.cc:47: __ ret(0); Ret() is an alternative to ret(0). http://codereview.chromium.org/6350021/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
