LGTM with a couple of fomatting nits.
http://codereview.chromium.org/6392027/diff/1/src/ia32/deoptimizer-ia32.cc File src/ia32/deoptimizer-ia32.cc (right): http://codereview.chromium.org/6392027/diff/1/src/ia32/deoptimizer-ia32.cc#newcode112 src/ia32/deoptimizer-ia32.cc:112: Address call_target_address = pc_after - kIntSize; This is really kPointerSize. http://codereview.chromium.org/6392027/diff/1/src/ia32/deoptimizer-ia32.cc#newcode113 src/ia32/deoptimizer-ia32.cc:113: ASSERT(check_code->entry() == Assembler::target_address_at( I would format this differently: ASSERT(check_code->entry() == Assembler::target_address_at(call_target_address)); http://codereview.chromium.org/6392027/diff/1/src/ia32/deoptimizer-ia32.cc#newcode137 src/ia32/deoptimizer-ia32.cc:137: replacement_code->entry()); Align with the other argument please. Assembler::set_target_address(arg0, arg1); http://codereview.chromium.org/6392027/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
