LGTM (with minor nitpicks) I will fix those nitpicks myself and land the patch.
Thanks for contributing! http://codereview.chromium.org/6371011/diff/38001/src/gdb-jit.cc File src/gdb-jit.cc (right): http://codereview.chromium.org/6371011/diff/38001/src/gdb-jit.cc#newcode711 src/gdb-jit.cc:711: GDBJITInterface::CodeTag get_tag() const { Getters don't have get_ prefix in Google C++ Code Style. http://codereview.chromium.org/6371011/diff/38001/src/gdb-jit.cc#newcode1061 src/gdb-jit.cc:1061: WriteFDEStateOne(w); This names are not informative. http://codereview.chromium.org/6371011/diff/38001/src/gdb-jit.cc#newcode1341 src/gdb-jit.cc:1341: This does not lint (did you run tools/presubmit.py?) http://codereview.chromium.org/6371011/diff/38001/src/gdb-jit.cc#newcode1344 src/gdb-jit.cc:1344: byte *code = reinterpret_cast<byte*>(cd->code_start()); This will fail to compile in release mode (due to unused variable). http://codereview.chromium.org/6371011/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
