Reviewers: Lasse Reichstein, Mads Ager,
Message:
A draft really, there are some pending questions:
- how to best sniff that caller is strict mode (pass argument to the runtime
functions, walk stack frames, ...)
- what to do about debugger (looking for the right contact with whom to
discuss
debugger issues)
Thank you!
Martin
http://codereview.chromium.org/6286043/diff/1/src/runtime.cc
File src/runtime.cc (right):
http://codereview.chromium.org/6286043/diff/1/src/runtime.cc#newcode7647
src/runtime.cc:7647: Handle<JSFunction>
caller(JSFunction::cast(frame->function()));
Alternative to walking the stack frames is passing additional argument
(strict mode flag). This works well but am not sure whether it is the
right way to do this. Open to suggestions.
http://codereview.chromium.org/6286043/diff/1/src/runtime.cc#newcode7671
src/runtime.cc:7671: JavaScriptFrame* frame =
locator.FindJavaScriptFrame(0);
Alternative to walking the stack frames is passing additional argument
(strict mode flag). This works well but am not sure whether it is the
right way to do this. Open to suggestions.
http://codereview.chromium.org/6286043/diff/1/src/runtime.cc#newcode9817
src/runtime.cc:9817: false);
Need to follow up with debugger folks what the right behavior is here.
Who is the best contact?
http://codereview.chromium.org/6286043/diff/1/src/runtime.cc#newcode9900
src/runtime.cc:9900: Compiler::CompileEval(source, context, is_global,
false);
ditto, follow up with debugger folks what the right behavior is.
Description:
Direct call to eval passes strict mode through.
BUG=
TEST=test/mjsunit/strict-mode-eval.js
Please review this at http://codereview.chromium.org/6286043/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/compiler.h
M src/compiler.cc
M src/objects-inl.h
M src/objects.h
M src/parser.h
M src/parser.cc
M src/runtime.cc
A test/mjsunit/strict-mode-eval.js
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
