Reviewers: Mads Ager, Description: Revert revision 6555 as it causes win32 debug to fail.
Please review this at http://codereview.chromium.org/6349044/ SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/api.cc M test/cctest/test-api.cc Index: src/api.cc =================================================================== --- src/api.cc (revision 6563) +++ src/api.cc (working copy) @@ -2200,12 +2200,6 @@ ENTER_V8; i::Handle<i::Object> obj = Utils::OpenHandle(this); i::Handle<i::Object> other = Utils::OpenHandle(*that); - // If both obj and other are JSObjects, we'd better compare by identity - // immediately when going into JS builtin. The reason is Invoke - // would overwrite global object receiver with global proxy. - if (obj->IsJSObject() && other->IsJSObject()) { - return *obj == *other; - } i::Object** args[1] = { other.location() }; EXCEPTION_PREAMBLE(); i::Handle<i::Object> result = Index: test/cctest/test-api.cc =================================================================== --- test/cctest/test-api.cc (revision 6563) +++ test/cctest/test-api.cc (working copy) @@ -12213,25 +12213,6 @@ } -THREADED_TEST(Equals) { - v8::HandleScope handleScope; - LocalContext localContext; - - v8::Handle<v8::Object> globalProxy = localContext->Global(); - v8::Handle<Value> global = globalProxy->GetPrototype(); - - CHECK(global->StrictEquals(global)); - CHECK(!global->StrictEquals(globalProxy)); - CHECK(!globalProxy->StrictEquals(global)); - CHECK(globalProxy->StrictEquals(globalProxy)); - - CHECK(global->Equals(global)); - CHECK(!global->Equals(globalProxy)); - CHECK(!globalProxy->Equals(global)); - CHECK(globalProxy->Equals(globalProxy)); -} - - static v8::Handle<v8::Value> Getter(v8::Local<v8::String> property, const v8::AccessorInfo& info ) { return v8_str("42!"); -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
