I also fixed the use of the pretenure-flags on function literals in the lithium
codegen.

Please have a look.



http://codereview.chromium.org/6240012/diff/6004/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):

http://codereview.chromium.org/6240012/diff/6004/src/hydrogen-instructions.h#newcode3085
src/hydrogen-instructions.h:3085: class HToFastProperties: public
HUnaryOperation {
On 2011/02/02 13:07:52, Mads Ager wrote:
Is it OK that this is not marked as changing maps when that is exactly
what it
is doing? I'm concerned that maybe code that relies on the new map can
be
hoisted to before this instruction where the map is not the same?

As discussed I'm making the return value of the ToFastProperties-call
the result of the whole object literal expression and assert that the
HToFastProperties is only used with an freshly created object literal as
input.

http://codereview.chromium.org/6240012/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to