LGTM I decided against the Push(r3, r2, r1, r0)
Committed: http://code.google.com/p/v8/source/detail?r=6599 http://codereview.chromium.org/6349052/diff/1/src/arm/lithium-codegen-arm.cc File src/arm/lithium-codegen-arm.cc (right): http://codereview.chromium.org/6349052/diff/1/src/arm/lithium-codegen-arm.cc#newcode1400 src/arm/lithium-codegen-arm.cc:1400: case Token::MOD: { Please use Push(r3, r2, r1, r0) http://codereview.chromium.org/6349052/diff/1/src/arm/lithium-codegen-arm.cc#newcode1411 src/arm/lithium-codegen-arm.cc:1411: // Restore r0-r3. We currently don't have a Pop(r0, r1, r2, r4), so maybe using Push is a bad idea. http://codereview.chromium.org/6349052/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
