Reviewers: Mads Ager, Message: This is a part of my earlier CL. I'd like to land it separately.
Description: Fix bug in pretenuring function literals from optimized code. Please review this at http://codereview.chromium.org/6368074/ SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/arm/lithium-codegen-arm.cc M src/ia32/lithium-codegen-ia32.cc Index: src/arm/lithium-codegen-arm.cc =================================================================== --- src/arm/lithium-codegen-arm.cc (revision 6591) +++ src/arm/lithium-codegen-arm.cc (working copy) @@ -3497,7 +3497,7 @@ // Use the fast case closure allocation code that allocates in new // space for nested functions that don't need literals cloning. Handle<SharedFunctionInfo> shared_info = instr->shared_info(); - bool pretenure = !instr->hydrogen()->pretenure(); + bool pretenure = instr->hydrogen()->pretenure(); if (shared_info->num_literals() == 0 && !pretenure) { FastNewClosureStub stub; __ mov(r1, Operand(shared_info)); Index: src/ia32/lithium-codegen-ia32.cc =================================================================== --- src/ia32/lithium-codegen-ia32.cc (revision 6591) +++ src/ia32/lithium-codegen-ia32.cc (working copy) @@ -3406,7 +3406,7 @@ // Use the fast case closure allocation code that allocates in new // space for nested functions that don't need literals cloning. Handle<SharedFunctionInfo> shared_info = instr->shared_info(); - bool pretenure = !instr->hydrogen()->pretenure(); + bool pretenure = instr->hydrogen()->pretenure(); if (shared_info->num_literals() == 0 && !pretenure) { FastNewClosureStub stub; __ push(Immediate(shared_info)); -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
