Reviewers: Mads Ager, Rico,
Message:
Guys,
tiniest review for you.
Description:
Fix array boundary error.
It made value of allowed_access_type[v8::ACCESS_KEYS] be a wild value. On
most
of
platforms it was 0 and tests passed. But on ARM (and on ia32 if you alter
test
a bit)
it could become true and hence allow enumeration of properties.
Please review this at http://codereview.chromium.org/6334089/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M test/cctest/test-api.cc
Index: test/cctest/test-api.cc
diff --git a/test/cctest/test-api.cc b/test/cctest/test-api.cc
index
b04420ed9ba6264b5be4dcfe30f4a01361b010f5..20a6f3e8267a5862cb17ed8462c5c6904ef9d8d4
100644
--- a/test/cctest/test-api.cc
+++ b/test/cctest/test-api.cc
@@ -5309,7 +5309,7 @@ TEST(DetachAndReattachGlobal) {
}
-static bool allowed_access_type[v8::ACCESS_KEYS] = { false };
+static bool allowed_access_type[v8::ACCESS_KEYS + 1] = { false };
static bool NamedAccessBlocker(Local<v8::Object> global,
Local<Value> name,
v8::AccessType type,
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
