comments addressed.
http://codereview.chromium.org/6368053/diff/1/src/arm/lithium-codegen-arm.cc File src/arm/lithium-codegen-arm.cc (right): http://codereview.chromium.org/6368053/diff/1/src/arm/lithium-codegen-arm.cc#newcode2670 src/arm/lithium-codegen-arm.cc:2670: EmitVFPTruncate(kRoundToMinusInf, On 2011/02/03 09:07:17, Søren Gjesse wrote:
To much indentation.
Done. http://codereview.chromium.org/6368053/diff/1/src/arm/lithium-codegen-arm.cc#newcode3334 src/arm/lithium-codegen-arm.cc:3334: EmitVFPTruncate(rounding_mode, On 2011/02/03 09:07:17, Søren Gjesse wrote:
Indentation.
Done. http://codereview.chromium.org/6368053/diff/1/src/arm/lithium-codegen-arm.cc#newcode3353 src/arm/lithium-codegen-arm.cc:3353: On 2011/02/03 09:07:17, Søren Gjesse wrote:
Indentation.
Done. http://codereview.chromium.org/6368053/diff/1/src/arm/simulator-arm.cc File src/arm/simulator-arm.cc (right): http://codereview.chromium.org/6368053/diff/1/src/arm/simulator-arm.cc#newcode2564 src/arm/simulator-arm.cc:2564: FPSCR_rounding_mode_ = On 2011/02/03 09:07:17, Søren Gjesse wrote:
4 char indent.
Done. http://codereview.chromium.org/6368053/diff/1/src/arm/simulator-arm.cc#newcode2665 src/arm/simulator-arm.cc:2665: (val < -0.5) || made a separate check for NaN. http://codereview.chromium.org/6368053/diff/1/src/arm/simulator-arm.cc#newcode2737 src/arm/simulator-arm.cc:2737: VFPRoundingMode mode = (instr->Bit(7) != 1) ? FPSCR_rounding_mode_ On 2011/02/03 09:07:17, Søren Gjesse wrote:
Indentation.
Done. http://codereview.chromium.org/6368053/diff/1/src/arm/simulator-arm.cc#newcode2747 src/arm/simulator-arm.cc:2747: int temp = unsigned_integer ? static_cast<uint32_t>(val) : On 2011/02/03 09:07:17, Søren Gjesse wrote:
Please be consistent with where the : is placed.
Done. http://codereview.chromium.org/6368053/diff/1/src/checks.h File src/checks.h (right): http://codereview.chromium.org/6368053/diff/1/src/checks.h#newcode76 src/checks.h:76: "CHECK_EQ(%s, %s) failed\n" On 2011/02/03 09:07:17, Søren Gjesse wrote:
I don't think we want tabs in the output.
Done. http://codereview.chromium.org/6368053/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
