http://codereview.chromium.org/6334083/diff/1/src/ia32/deoptimizer-ia32.cc File src/ia32/deoptimizer-ia32.cc (right):
http://codereview.chromium.org/6334083/diff/1/src/ia32/deoptimizer-ia32.cc#newcode93 src/ia32/deoptimizer-ia32.cc:93: RelocInfo rinfo(curr_address + 1, // address is 1 after the call opcode On 2011/02/03 09:44:26, Rico wrote:
Period at end of comment
I didn't intend it to be a complete sentence, but I guess it accidentally is. http://codereview.chromium.org/6334083/diff/1/src/ia32/deoptimizer-ia32.cc#newcode94 src/ia32/deoptimizer-ia32.cc:94: RelocInfo::RUNTIME_ENTRY, On 2011/02/03 09:44:26, Rico wrote:
Maybe we should have a comment stating: "We use
RelocInfo::RUNTIME_ENTRY to mark
that the actual call address is not moving, even though this is not a
runtime
entry
OK. http://codereview.chromium.org/6334083/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
