http://codereview.chromium.org/6384020/diff/1/src/ia32/lithium-ia32.cc File src/ia32/lithium-ia32.cc (right):
http://codereview.chromium.org/6384020/diff/1/src/ia32/lithium-ia32.cc#newcode1697 src/ia32/lithium-ia32.cc:1697: value = UseRegisterAtStart(instr->value()); On 2011/02/04 11:29:58, fschneider wrote:
This is perfectly valid, but i think the AtStart will not have any
benefit since
there are no temps or result registers here.
I was trying to be consistent, but I guess UseRegister is a safer default so I'll switch to that. http://codereview.chromium.org/6384020/diff/1/src/ia32/macro-assembler-ia32.cc File src/ia32/macro-assembler-ia32.cc (right): http://codereview.chromium.org/6384020/diff/1/src/ia32/macro-assembler-ia32.cc#newcode1537 src/ia32/macro-assembler-ia32.cc:1537: cmp(dst, Operand(dst, Context::SlotOffset(Context::FCONTEXT_INDEX))); On 2011/02/04 11:29:58, fschneider wrote:
Shouldn't this be inside if (FLAG_debug_code)?
Good catch. http://codereview.chromium.org/6384020/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
