Reviewers: Mads Ager, Lasse Reichstein,
Message:
Hi Mads, Lasse,
should have anticipated this one... The strict mode part of the es5conform
suite
was hiding behind a gate:
function isStrictSupported() {
"use strict";
try {
eval("with({}){};")
return false;
} catch (e) {
return e instanceof SyntaxError;
}
}
which I enabled with the eval commit. All of a sudden the strict mode tests
actually run. Some fail because the strict mode implementation is not
complete,
others fail because thee tests themselves are not correct in places.
I adjusted the expectations file and put comments in there to note why each
test
fails.
Thank you!
Martin
Description:
Fix es5conform.status expectation file.
The strict mode tests in es5conform suite were disabled until now.
The propagation of strict mode flag into eval enabled them but
there are failures due to:
* unimplemented features of strict mode
* some incorrect tests in the suite.
[email protected], [email protected]
BUG=
TEST=es5conform
Please review this at http://codereview.chromium.org/6396008/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M test/es5conform/es5conform.status
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
