I don't think we want to put #pragma lines in the source. See comment. So we need to find another way to disable the warning.
http://codereview.chromium.org/6286135/diff/1/src/bignum.cc File src/bignum.cc (right): http://codereview.chromium.org/6286135/diff/1/src/bignum.cc#newcode752 src/bignum.cc:752: static_cast<Chunk>(bigits_[i + exponent_diff] - (remove & kBigitMask)); Can this static_cast<Chunk> be applied just to (remove & kBigitMask), instead of the whole expression? http://codereview.chromium.org/6286135/diff/1/src/ia32/lithium-gap-resolver-ia32.cc File src/ia32/lithium-gap-resolver-ia32.cc (right): http://codereview.chromium.org/6286135/diff/1/src/ia32/lithium-gap-resolver-ia32.cc#newcode37 src/ia32/lithium-gap-resolver-ia32.cc:37: #endif // _MSC_VER Can't we disable the warning as a setting in the VS 2005 project file, without inserting #pragma lines in the source. I don't think we want to allow this, and we might choose to initialize these explicitly rather than have to add the pragma. We disabled the warning in the SCons and the gyp builds, I think. http://codereview.chromium.org/6286135/diff/1/src/profile-generator.cc File src/profile-generator.cc (right): http://codereview.chromium.org/6286135/diff/1/src/profile-generator.cc#newcode2288 src/profile-generator.cc:2288: // Softw. Pract. Exper. 4 (2001), pp. 1-10. Good. http://codereview.chromium.org/6286135/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
