LGTM
Please add yourself to the AUTHORS file and fix one nit (see below,
regarding
the names of variables).
After that I will land the patch.
Thanks for contributing!
http://codereview.chromium.org/6368116/diff/1/src/uri.js
File src/uri.js (right):
http://codereview.chromium.org/6368116/diff/1/src/uri.js#newcode95
src/uri.js:95: var m = HexValueOf(code2);
Please give more meaningful names to this variables.
For example: high and low.
http://codereview.chromium.org/6368116/diff/1/src/uri.js#newcode99
src/uri.js:99: return n * 16 + m;
Have you considered using
(high << 4) | low
instead of
n * 16 + m?
It might be slightly faster.
http://codereview.chromium.org/6368116/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
