http://codereview.chromium.org/6450003/diff/1/src/runtime.cc File src/runtime.cc (right):
http://codereview.chromium.org/6450003/diff/1/src/runtime.cc#newcode881 src/runtime.cc:881: static MaybeObject* Runtime_PreventExtensions(Arguments args) { On 2011/02/08 13:04:22, Mads Ager wrote:
Do you need it here too?
No, we do this in PreventExtensions in objects.cc http://codereview.chromium.org/6450003/diff/1/src/runtime.cc#newcode892 src/runtime.cc:892: if (proto->IsNull()) return obj; On 2011/02/08 13:04:22, Mads Ager wrote:
Return false? Otherwise this will be interpreted as true.
Done. http://codereview.chromium.org/6450003/diff/1/src/runtime.cc#newcode896 src/runtime.cc:896: return obj->map()->is_extensible() ? Heap::true_value() On 2011/02/08 13:04:22, Mads Ager wrote:
Remove extra space.
Done. http://codereview.chromium.org/6450003/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
