LGTM.
http://codereview.chromium.org/6452002/diff/1/src/ia32/lithium-codegen-ia32.cc File src/ia32/lithium-codegen-ia32.cc (right): http://codereview.chromium.org/6452002/diff/1/src/ia32/lithium-codegen-ia32.cc#newcode955 src/ia32/lithium-codegen-ia32.cc:955: __ Set(temp, Immediate(lower)); Have you considered using the pinsrd instruction to copy a 32-bit GP register directly to bits 32..63 of an XMM register? This is only in SSE 4.1. http://codereview.chromium.org/6452002/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
