LGTM
http://codereview.chromium.org/6451003/diff/1/src/runtime.cc File src/runtime.cc (right): http://codereview.chromium.org/6451003/diff/1/src/runtime.cc#newcode1093 src/runtime.cc:1093: if (result.is_null()) return Failure::Exception(); I know we do not typically do it, so feel free to ignore, but maybe we should add something like ASSERT(Top::has_pending_exception()) on bailouts and ASSERT(!Top::has_pending_exception()) on normal path. But again, we don't typically do it. http://codereview.chromium.org/6451003/diff/1/test/mjsunit/regress/regress-1105.js File test/mjsunit/regress/regress-1105.js (right): http://codereview.chromium.org/6451003/diff/1/test/mjsunit/regress/regress-1105.js#newcode31 test/mjsunit/regress/regress-1105.js:31: this.eval('__defineSetter__("x",function(){throw 42;});') why eval here? Couldn't it be plain this.__defineSetter__ ? http://codereview.chromium.org/6451003/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
