Good catch! Thanks! -- Vyacheslav Egorov
On Tue, Feb 8, 2011 at 5:53 PM, <[email protected]> wrote: > drive by comments > > > http://codereview.chromium.org/6453005/diff/1/src/arm/macro-assembler-arm.cc > File src/arm/macro-assembler-arm.cc (right): > > http://codereview.chromium.org/6453005/diff/1/src/arm/macro-assembler-arm.cc#newcode1154 > src/arm/macro-assembler-arm.cc:1154: b(cs, gc_required); > You need to set the flags in the add instruction above (SetCC > parameter). > > http://codereview.chromium.org/6453005/diff/1/src/arm/macro-assembler-arm.cc#newcode1237 > src/arm/macro-assembler-arm.cc:1237: b(cs, gc_required); > ditto. > > http://codereview.chromium.org/6453005/ > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
