LGTM when this comment is addressed.
http://codereview.chromium.org/6451004/diff/6002/src/objects.cc File src/objects.cc (right): http://codereview.chromium.org/6451004/diff/6002/src/objects.cc#newcode1728 src/objects.cc:1728: return Heap::the_hole_value(); Can we do an output parameter called something like |found| instead? Then the callers can do: bool called_setter; MaybeObject* result = SetElementWithCallbackSetterInPrototypes(..., &called_setter); if (called_setter) return result; http://codereview.chromium.org/6451004/diff/6002/src/objects.h File src/objects.h (right): http://codereview.chromium.org/6451004/diff/6002/src/objects.h#newcode1582 src/objects.h:1582: MUST_USE_RESULT MaybeObject* Can you split the line after the name and put the arguments on the new line or is that too long? http://codereview.chromium.org/6451004/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
