http://codereview.chromium.org/6463001/diff/1/src/runtime.cc File src/runtime.cc (right):
http://codereview.chromium.org/6463001/diff/1/src/runtime.cc#newcode7394 src/runtime.cc:7394: Handle<Context>::cast(holder)->set(index, *value); Agree, but in this case I am afraid we cannot use SetElement as a context is a fixed array actually. Good news is set should be GC safe. I slightly reworked this line (to have lesser mixture of handles and non-handles stuff) and added a comment explaining why it's safe. On 2011/02/09 07:03:36, Mads Ager wrote:
Do you know that this one cannot fail? Code that is a handle
non-handle mix is
always scary. Let's do this one in a GC safe way as well.
http://codereview.chromium.org/6463001/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
