http://codereview.chromium.org/6452001/diff/1/src/hydrogen-instructions.h File src/hydrogen-instructions.h (right):
http://codereview.chromium.org/6452001/diff/1/src/hydrogen-instructions.h#newcode1181 src/hydrogen-instructions.h:1181: // (see HCall). Maybe it would be less effort to land the refactoring of PushArguments first - all this code will be greatly cleaned up afterwards. http://codereview.chromium.org/6452001/diff/1/src/ia32/lithium-codegen-ia32.cc File src/ia32/lithium-codegen-ia32.cc (right): http://codereview.chromium.org/6452001/diff/1/src/ia32/lithium-codegen-ia32.cc#newcode377 src/ia32/lithium-codegen-ia32.cc:377: if (!adjusted) { Is there a convenient way to assert that "!adjusted || there is a fixed use of the context in esi"? http://codereview.chromium.org/6452001/diff/1/src/ia32/lithium-ia32.cc File src/ia32/lithium-ia32.cc (right): http://codereview.chromium.org/6452001/diff/1/src/ia32/lithium-ia32.cc#newcode1237 src/ia32/lithium-ia32.cc:1237: LOperand* context = UseFixed(instr->context(), esi); I'm not sure if it is worth mentioning the context as input operand. It seems that we have to reload it from the stack before most calls anyway. Is there a big performance impact of always reloading it from the stack before a call as part of CallCode or CallRuntime? http://codereview.chromium.org/6452001/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
