Just a few comments. The v8 benchmarks performance improvement are impressive!
Alexandre http://codereview.chromium.org/6461017/diff/1/src/arm/assembler-arm.cc File src/arm/assembler-arm.cc (right): http://codereview.chromium.org/6461017/diff/1/src/arm/assembler-arm.cc#newcode355 src/arm/assembler-arm.cc:355: Condition Assembler::GetCondition(Instr instr) { Same as Instruction::ConditionField(). Do we want to redefine this? http://codereview.chromium.org/6461017/diff/1/src/arm/assembler-arm.cc#newcode514 src/arm/assembler-arm.cc:514: Not sure, but should we move these to the Instruction class in constants-arm.* ? http://codereview.chromium.org/6461017/diff/1/src/arm/assembler-arm.h File src/arm/assembler-arm.h (right): http://codereview.chromium.org/6461017/diff/1/src/arm/assembler-arm.h#newcode1103 src/arm/assembler-arm.h:1103: static Condition GetCondition(Instr instr); Same as Instruction::ConditionField(). Do we want to redefine this? http://codereview.chromium.org/6461017/diff/1/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right): http://codereview.chromium.org/6461017/diff/1/src/arm/code-stubs-arm.cc#newcode1301 src/arm/code-stubs-arm.cc:1301: Register scratch = r9; Is this more readable? Register scratch = r9.is(tos_) ? r7 : r9; http://codereview.chromium.org/6461017/diff/1/src/arm/constants-arm.h File src/arm/constants-arm.h (right): http://codereview.chromium.org/6461017/diff/1/src/arm/constants-arm.h#newcode144 src/arm/constants-arm.h:144: kConditionMask = 15 << 28 // Mask for the condition field. kCondMask was already defined (~line 259). I think we should keep only one; but I think any of them is fine though. http://codereview.chromium.org/6461017/diff/1/src/arm/full-codegen-arm.cc File src/arm/full-codegen-arm.cc (right): http://codereview.chromium.org/6461017/diff/1/src/arm/full-codegen-arm.cc#newcode50 src/arm/full-codegen-arm.cc:50: // class has a number of methods the emit the code which is patchable and the typo: "the emit the code" -> "to emit the code" ? http://codereview.chromium.org/6461017/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
