LGTM
http://codereview.chromium.org/6460034/diff/4002/src/arm/deoptimizer-arm.cc File src/arm/deoptimizer-arm.cc (right): http://codereview.chromium.org/6460034/diff/4002/src/arm/deoptimizer-arm.cc#newcode170 src/arm/deoptimizer-arm.cc:170: int count = iterator.Next(); count -> frame_count for clarity? http://codereview.chromium.org/6460034/diff/4002/src/arm/deoptimizer-arm.cc#newcode498 src/arm/deoptimizer-arm.cc:498: // Correct two words for bailout id and return address. Looking at TableEntryGenerator::GeneratePrologue do we actually have to do push(lr)/nop() there after all? Maybe just pushing the bailout id (and adjusting Deoptimizer::table_entry_size_) should be enough. You don't have to try that in this CL. http://codereview.chromium.org/6460034/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
