http://codereview.chromium.org/6471023/diff/5/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right):
http://codereview.chromium.org/6471023/diff/5/src/arm/code-stubs-arm.cc#newcode2778 src/arm/code-stubs-arm.cc:2778: // Use only the 5 least significant bits of the shift count. You have a macro assembler thing for this that you use above? http://codereview.chromium.org/6471023/diff/5/src/arm/code-stubs-arm.cc#newcode2784 src/arm/code-stubs-arm.cc:2784: __ and_(r2, r2, Operand(0x1f)); Ditto? http://codereview.chromium.org/6471023/diff/5/src/arm/code-stubs-arm.cc#newcode2798 src/arm/code-stubs-arm.cc:2798: __ and_(r2, r2, Operand(0x1f)); And here. http://codereview.chromium.org/6471023/diff/5/src/arm/full-codegen-arm.cc File src/arm/full-codegen-arm.cc (right): http://codereview.chromium.org/6471023/diff/5/src/arm/full-codegen-arm.cc#newcode1616 src/arm/full-codegen-arm.cc:1616: __ CallStub(&stub); Do you have to be careful that you do not accidentally get something after this call that marks it as having inlined smi code? http://codereview.chromium.org/6471023/diff/5/src/arm/lithium-arm.cc File src/arm/lithium-arm.cc (right): http://codereview.chromium.org/6471023/diff/5/src/arm/lithium-arm.cc#newcode189 src/arm/lithium-arm.cc:189: case Token::SHL: return "sal-t"; sal -> shl http://codereview.chromium.org/6471023/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
