Thanks a lot for review, Kevin.

I also raised the constant slightly to allow test to run under x64 and disabled
it for ARM.

Submitting


http://codereview.chromium.org/6487021/diff/4001/src/flag-definitions.h
File src/flag-definitions.h (right):

http://codereview.chromium.org/6487021/diff/4001/src/flag-definitions.h#newcode235
src/flag-definitions.h:235: DEFINE_int(stack_size_kb, kPointerSize *
128,
On 2011/02/11 12:55:47, Kevin Millikin wrote:
For the heap limits, the flag is something like max_new_space_size and
the
string help comment gives the units.

You could do that here for consistency, but I don't care too much
either way.

Unified with max_new_space_size.

http://codereview.chromium.org/6487021/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to