Thanks for the review! Fixed the test (added the loop tests) and committed.
http://codereview.chromium.org/6474026/diff/1/test/mjsunit/strict-mode.js File test/mjsunit/strict-mode.js (right): http://codereview.chromium.org/6474026/diff/1/test/mjsunit/strict-mode.js#newcode352 test/mjsunit/strict-mode.js:352: testAssignToUndefined(true); On 2011/02/11 08:08:09, Mads Ager wrote:
On 2011/02/11 03:06:59, MarkM wrote: > Why are you calling this three times for each case?
In order to make sure that ICs are initialized and used, the first
time through
the code the ICs are not yet initialized and everything is taken care
of in the
runtime system.
Martin, can you put this in a loop and do it 10 times for each? That
way we have
a bit more slack if we change the heuristics for when to generate new
ICs and
patch the code.
Done. http://codereview.chromium.org/6474026/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
